Skip to content

Linux 3.10 proc new interface #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
azat wants to merge 17 commits into from
Closed

Linux 3.10 proc new interface #60

azat wants to merge 17 commits into from

Conversation

@azat
Copy link
Contributor

@azat azat commented Jul 21, 2013

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a problem.
Any remarks are welcome.

Thanks.

azat added 16 commits July 21, 2013 02:32
@azat
driver: fix creating of entries in proc-fs for linux 3.10
f75a995
@azat
driver: proc: use seq_show function for basic added proc entries
02f0ada
@azat
driver: proc: missing include of linux/seq_file.h
794e275
@azat
driver: debug proc: fix return value for show callback
3398cb9
@azat
driver: proc_dtrace_security_show(): drop unsed variables
22bb56d 
Unstable patch
@azat
driver: fix file_operations.open callbacks
cc9086b
@azat
driver: proc_dtrace_stats_show(): drop undefined variable usage
65455a9
@azat
driver: proc_dtrace_stats_show(): drop deprecated variables
29352e6 
Unstable
@azat
driver: there is no seq_nprintf() function, replace by seq_printf()
2f85d05
@azat
driver: implement proc_dtrace_trace_write_proc() callback
c302479 
Possible unstable patch
@azat
driver: implement proc_dtrace_trace_show() callback
72a3fc6 
Possible incorrect behaviour
@azat
driver: add {llseek,release} default callbacks
5ca298c
@azat
driver: use single_open() instead of seq_open() for proc/dtrace/debug
19cd89a
@azat
driver: use single_open() instead seq_open() for /proc/dtrace/security
556f513
@azat
driver: use single_open() instead of seq_open() for /proc/dtrace/stats
00c3d9f
@azat
driver: use single_open() instead of seq_open() for /proc/dtrace/trace
9ae1fe0
@dtrace4linux
Copy link
Owner

dtrace4linux commented Jul 21, 2013

Azat - I dont understand the nature of these changes. The existing code
compiles on all kernels - validated up to 3.9. I havent tried 3.10 yet. Has
seq_open() disappeared in 3.10?

thanks

On 21 July 2013 11:52, Azat Khuzhin notifications@github.com wrote:

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a problem.
Any remarks are welcome.

Thanks.

You can merge this Pull Request by running

git pull https://github.com/azat/dtrace4linux linux-3.10-proc-new-interface

Or view, comment on, or merge it at:

#60
Commit Summary

  • driver: fix creating of entries in proc-fs for linux 3.10
  • driver: proc: use seq_show function for basic added proc entries
  • driver: proc: missing include of linux/seq_file.h
  • driver: debug proc: fix return value for show callback
  • driver: proc_dtrace_security_show(): drop unsed variables
  • driver: fix file_operations.open callbacks
  • driver: proc_dtrace_stats_show(): drop undefined variable usage
  • driver: proc_dtrace_stats_show(): drop deprecated variables
  • driver: there is no seq_nprintf() function, replace by seq_printf()
  • driver: implement proc_dtrace_trace_write_proc() callback
  • driver: implement proc_dtrace_trace_show() callback
  • driver: add {llseek,release} default callbacks
  • driver: use single_open() instead of seq_open() for proc/dtrace/debug
  • driver: use single_open() instead seq_open() for
    /proc/dtrace/security
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/stats
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/trace

File Changes

Patch Links:

@azat
Copy link
Contributor Author

azat commented Jul 21, 2013

No seq_open() is still there, disappears create_proc_entry()

Thanks

On Mon, Jul 22, 2013 at 12:27 AM, dtrace4linux notifications@github.comwrote:

Azat - I dont understand the nature of these changes. The existing code
compiles on all kernels - validated up to 3.9. I havent tried 3.10 yet. Has
seq_open() disappeared in 3.10?

thanks

On 21 July 2013 11:52, Azat Khuzhin notifications@github.com wrote:

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a problem.
Any remarks are welcome.

Thanks.

You can merge this Pull Request by running

git pull https://github.com/azat/dtrace4linuxlinux-3.10-proc-new-interface

Or view, comment on, or merge it at:

#60
Commit Summary

  • driver: fix creating of entries in proc-fs for linux 3.10
  • driver: proc: use seq_show function for basic added proc entries
  • driver: proc: missing include of linux/seq_file.h
  • driver: debug proc: fix return value for show callback
  • driver: proc_dtrace_security_show(): drop unsed variables
  • driver: fix file_operations.open callbacks
  • driver: proc_dtrace_stats_show(): drop undefined variable usage
  • driver: proc_dtrace_stats_show(): drop deprecated variables
  • driver: there is no seq_nprintf() function, replace by seq_printf()
  • driver: implement proc_dtrace_trace_write_proc() callback
  • driver: implement proc_dtrace_trace_show() callback
  • driver: add {llseek,release} default callbacks
  • driver: use single_open() instead of seq_open() for proc/dtrace/debug
  • driver: use single_open() instead seq_open() for
    /proc/dtrace/security
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/stats
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/trace

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-21316384
.

@dtrace4linux
Copy link
Owner

dtrace4linux commented Jul 22, 2013

Great. So do your changes fail for all the old kernels?
On 21 Jul 2013 22:17, "Azat Khuzhin" notifications@github.com wrote:

No seq_open() is still there, disappears create_proc_entry()

Thanks

On Mon, Jul 22, 2013 at 12:27 AM, dtrace4linux notifications@github.comwrote:

Azat - I dont understand the nature of these changes. The existing code
compiles on all kernels - validated up to 3.9. I havent tried 3.10 yet.
Has
seq_open() disappeared in 3.10?

thanks

On 21 July 2013 11:52, Azat Khuzhin notifications@github.com wrote:

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a
problem.
Any remarks are welcome.

Thanks.

You can merge this Pull Request by running

git pull
https://github.com/azat/dtrace4linuxlinux-3.10-proc-new-interface

Or view, comment on, or merge it at:

#60
Commit Summary

  • driver: fix creating of entries in proc-fs for linux 3.10
  • driver: proc: use seq_show function for basic added proc entries
  • driver: proc: missing include of linux/seq_file.h
  • driver: debug proc: fix return value for show callback
  • driver: proc_dtrace_security_show(): drop unsed variables
  • driver: fix file_operations.open callbacks
  • driver: proc_dtrace_stats_show(): drop undefined variable usage
  • driver: proc_dtrace_stats_show(): drop deprecated variables
  • driver: there is no seq_nprintf() function, replace by seq_printf()
  • driver: implement proc_dtrace_trace_write_proc() callback
  • driver: implement proc_dtrace_trace_show() callback
  • driver: add {llseek,release} default callbacks
  • driver: use single_open() instead of seq_open() for
    proc/dtrace/debug
  • driver: use single_open() instead seq_open() for
    /proc/dtrace/security
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/stats
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/trace

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/dtrace4linux/linux/pull/60#issuecomment-21316384>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-21317220
.

@azat
Copy link
Contributor Author

azat commented Jul 22, 2013

No, I've add proc_compat.h, where bindings for old kernels located.

But I just remember, that condition for KERNEL_VERSION < 3.10 is not
enough there, because proc_create_data() added not in 3.10, but long
time before in 2.6.32,
So if dtrace4linux, didn't support kernels < 2.6.32, we can drop proc_compat.h

On Jul 22, 2013 11:24 AM, "dtrace4linux" notifications@github.com wrote:

Great. So do your changes fail for all the old kernels?
On 21 Jul 2013 22:17, "Azat Khuzhin" notifications@github.com wrote:

No seq_open() is still there, disappears create_proc_entry()

Thanks

On Mon, Jul 22, 2013 at 12:27 AM, dtrace4linux notifications@github.comwrote:

Azat - I dont understand the nature of these changes. The existing code
compiles on all kernels - validated up to 3.9. I havent tried 3.10 yet.
Has
seq_open() disappeared in 3.10?

thanks

On 21 July 2013 11:52, Azat Khuzhin notifications@github.com wrote:

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a
problem.
Any remarks are welcome.

Thanks.

You can merge this Pull Request by running

git pull
https://github.com/azat/dtrace4linuxlinux-3.10-proc-new-interface

Or view, comment on, or merge it at:

#60
Commit Summary

  • driver: fix creating of entries in proc-fs for linux 3.10
  • driver: proc: use seq_show function for basic added proc entries
  • driver: proc: missing include of linux/seq_file.h
  • driver: debug proc: fix return value for show callback
  • driver: proc_dtrace_security_show(): drop unsed variables
  • driver: fix file_operations.open callbacks
  • driver: proc_dtrace_stats_show(): drop undefined variable usage
  • driver: proc_dtrace_stats_show(): drop deprecated variables
  • driver: there is no seq_nprintf() function, replace by seq_printf()
  • driver: implement proc_dtrace_trace_write_proc() callback
  • driver: implement proc_dtrace_trace_show() callback
  • driver: add {llseek,release} default callbacks
  • driver: use single_open() instead of seq_open() for
    proc/dtrace/debug
  • driver: use single_open() instead seq_open() for
    /proc/dtrace/security
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/stats
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/trace

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub<
https://github.com/dtrace4linux/linux/pull/60#issuecomment-21316384>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-21317220
.

—
Reply to this email directly or view it on GitHub.

@azat azat mentioned this pull request Jul 22, 2013
Open
@dtrace4linux
Copy link
Owner

dtrace4linux commented Jul 22, 2013

Ive accepted the patch but proc_compat.h needs to change for <2.6.25
kernels. I've made a fix.

On 21 July 2013 11:52, Azat Khuzhin notifications@github.com wrote:

Here is migration to new proc-fs interface.
create_proc_entry() -> proc_create*()

Here is 16 patches, but I can rebase it into one, this is not a problem.
Any remarks are welcome.

Thanks.

You can merge this Pull Request by running

git pull https://github.com/azat/dtrace4linux linux-3.10-proc-new-interface

Or view, comment on, or merge it at:

#60
Commit Summary

  • driver: fix creating of entries in proc-fs for linux 3.10
  • driver: proc: use seq_show function for basic added proc entries
  • driver: proc: missing include of linux/seq_file.h
  • driver: debug proc: fix return value for show callback
  • driver: proc_dtrace_security_show(): drop unsed variables
  • driver: fix file_operations.open callbacks
  • driver: proc_dtrace_stats_show(): drop undefined variable usage
  • driver: proc_dtrace_stats_show(): drop deprecated variables
  • driver: there is no seq_nprintf() function, replace by seq_printf()
  • driver: implement proc_dtrace_trace_write_proc() callback
  • driver: implement proc_dtrace_trace_show() callback
  • driver: add {llseek,release} default callbacks
  • driver: use single_open() instead of seq_open() for proc/dtrace/debug
  • driver: use single_open() instead seq_open() for
    /proc/dtrace/security
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/stats
  • driver: use single_open() instead of seq_open() for
    /proc/dtrace/trace

File Changes

Patch Links:

@azat
driver/proc: add compat functions only if kernel < 2.6.25
1a3208f 
I remember that Paul, wrote he made a fix by him self, but I also need
this, so I fixed it by myself.
@rickyzhang82
Copy link

rickyzhang82 commented Aug 23, 2013

Has the patch push to master branch yet? I still encounter error related to create_proc_entry in 3.10

@dtrace4linux
Copy link
Owner

dtrace4linux commented Aug 23, 2013

No. I am out til tue or so...so not much happening for next few days.
On 23 Aug 2013 12:23, "rickyzhang82" notifications@github.com wrote:

Has the patch push to master branch yet? I still encounter error related
to create_proc_entry in 3.10

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-23183601
.

@azat
Copy link
Contributor Author

azat commented Aug 23, 2013

No. This patch is not in master. You can get version from my fork, but I
have some other patches merged also.

But I don't think that this is a problem.
On 24 Aug 2013 00:12, "rickyzhang82" notifications@github.com wrote:

Has the patch push to master branch yet? I still encounter error related
to create_proc_entry in 3.10

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-23183601
.

@rickyzhang82
Copy link

rickyzhang82 commented Aug 24, 2013

Thanks for you info.

@azat
Copy link
Contributor Author

azat commented Sep 23, 2014

This was merged into upstream. I'm closing the issue.

@azat azat closed this Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @dtrace4linux @rickyzhang82