Iso8583 v1.3.5 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2017 09:50
…it types A, N, and ANS, ValueTypeError raised when trying to set a value that is not a valid type
Owner
Author
|
Hello @ducminhgd, have you had any answer about the merge request?
Regards.
…On Dec 20, 2017 10:29, "Giã Dương Đức Minh" ***@***.***> wrote:
@dat07cs <https://github.com/dat07cs>, I do not maintain this repository
anymore, please help me to verify if this update from @R2RITO
<https://github.com/r2rito> resolves issues that he or she mentioned or
not.
Thank you both!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFP09egonxWSEG37GE9QjlrIIb4IRD0zks5tCRnQgaJpZM4RIcBa>
.
|
dat07cs
reviewed
Dec 22, 2017
ISO8583/ISO8583.py
Outdated
| raise ValueToLarge('Error: value up to size! Bit[%s] of type %s limit size = %s' % ( | ||
| bit, self.getBitType(bit), self.getBitLimit(bit))) | ||
|
|
||
| if not value.isalpha(): |
Collaborator
There was a problem hiding this comment.
Bit Type A can have alpha, including blank, characters
dat07cs
reviewed
Dec 22, 2017
ISO8583/ISO8583.py
Outdated
| raise ValueToLarge('Error: value up to size! Bit[%s] of type %s limit size = %s' % ( | ||
| bit, self.getBitType(bit), self.getBitLimit(bit))) | ||
|
|
||
| if not value.isalnum(): |
Collaborator
There was a problem hiding this comment.
Bit Type ANS can have alphanumeric and special characters
dat07cs
reviewed
Dec 22, 2017
ISO8583/ISO8583.py
Outdated
| if bitType == 'N' and not value.isdecimal(): | ||
| self.__raiseValueTypeError(cont) | ||
|
|
||
| if bitType == 'A' and not value.isalpha(): |
Collaborator
There was a problem hiding this comment.
As said, bit type A can have blank character
dat07cs
reviewed
Dec 22, 2017
ISO8583/ISO8583.py
Outdated
| bit, self.getBitType(bit), self.getBitLimit(bit))) | ||
|
|
||
| if not value.isdecimal(): | ||
| __raiseValueTypeError(bit) |
dat07cs
requested changes
Dec 22, 2017
Collaborator
dat07cs
left a comment
dat07cs
left a comment
There was a problem hiding this comment.
- miss reference to "self" object
- bit type A can have blank character
- bit type ANS can have special characters
…idity, added function to set bits of type AN
R2RITO
commented
Dec 22, 2017
Author
R2RITO
left a comment
R2RITO
left a comment
There was a problem hiding this comment.
Corrected the errors, added a new function and restructured some of the code. Please review.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for byte encoding on python3 in the getNetworkISO method since it is not automatically converted from bytes to ascii or unicode strings.
Added function to raise an InvalidValueType exception, used to avoid repeating code.
Added verification on type for the bit setting methods, on iso creation and on usage of setBit method. Bit type verification only for types A, N, ANS.