Feat/timeout hack - setValueNoAck()#11
Merged
dufourgilles merged 3 commits intodufourgilles:masterfrom Mar 5, 2020
Merged
Conversation
added 3 commits
February 26, 2020 08:56
…w() function from NRKNO fork
doc: Added comments to explain reason for hack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: setValueNoAck() function
This Hack solves timeout problems when setting the same value twice as seen on Lawo desks. (and probably other equipment)
It's based on a hack in the NRKNO fork and gives the speed needed on Lawo desks, to do a realtime fade.
In the NRKNO forks it's called setValueWithHacksaw() but after conversation with them we agreed on setValueNoAck()