Use libipmiconsole defaults from libipmiconsole.conf if set #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library libipmiconsole allows you to set defaults via the config file libipmiconsole.conf. However, these defaults are not used unless the engine_config flags are initialized with all bits toggled to 1. This functionality is useful for setting flags such as: libipmiconsole-context-engine-flags serialkeepalive Which was necessary for Dell's ipmi SOL implementation, which upon connection establishment does not send any output from the server until an input character is sent on stdin. This renders conman's console logging useless you manually connect to each console. However, using the serialkeepalive setting, the '\0' char triggers the connection to start sending output.
The config file libipmiconsole.conf can also specify workaround-flags. But conmand initializes the IPMI workaround-flags to 0 which indicates no workarounds (thereby overriding the standard libipmiconsole default or one configured via libipmiconsole.conf). This commit fixes that behavior. IPMI workaround-flags are initialized to the standard libipmiconsole default which can be overridden in either libipmiconsole.conf (via libipmiconsole-context-workaround-flags) or conman.conf (via ipmiopts). Signed-off-by: Chris Dunlap <cdunlap@llnl.gov>
Owner
|
Looks good, but don't the workaround-flags have the same problem? I've pushed a commit that (hopefully) addresses that. Can you give it a test in your setup? |
Contributor
Author
|
thanks @dun I have confirmed in my environment that your additional patch allows you to set default workaround flags in libipmiconsole.conf, that are then picked up by conman. |
dun
pushed a commit
that referenced
this pull request
Dec 12, 2017
The library libipmiconsole allows you to set defaults via the config file libipmiconsole.conf. However, these defaults are not used unless the engine_config flags are initialized with all bits toggled to 1. This functionality is useful for setting flags such as: libipmiconsole-context-engine-flags serialkeepalive Which was necessary for Dell's ipmi SOL implementation, which upon connection establishment does not send any output from the server until an input character is sent on stdin. This renders conman's console logging useless you manually connect to each console. However, using the serialkeepalive setting, the '\0' char triggers the connection to start sending output. Signed-off-by: lollipopman <jesse@mbuki-mvuki.org> Signed-off-by: Chris Dunlap <cdunlap@llnl.gov> PR #27
dun
added a commit
that referenced
this pull request
Dec 12, 2017
The config file libipmiconsole.conf can also specify workaround-flags. But conmand initializes the IPMI workaround-flags to 0 which indicates no workarounds (thereby overriding the standard libipmiconsole default or one configured via libipmiconsole.conf). This commit fixes that behavior. IPMI workaround-flags are initialized to the standard libipmiconsole default which can be overridden in either libipmiconsole.conf (via libipmiconsole-context-workaround-flags) or conman.conf (via ipmiopts). Signed-off-by: Chris Dunlap <cdunlap@llnl.gov> Signed-off-by: lollipopman <jesse@mbuki-mvuki.org> PR #27
Owner
|
I'll try to get 0.2.9 out this week. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library libipmiconsole allows you to set defaults via the config
file libipmiconsole.conf. However, these defaults are not used unless
the engine_config flags are initialized with all bits toggled to 1.
This functionality is useful for setting flags such as:
libipmiconsole-context-engine-flags serialkeepalive
Which was necessary for Dell's ipmi SOL implementation, which upon
connection establishment does not send any output from the server until
an input character is sent on stdin. This renders conman's console
logging useless you manually connect to each console. However, using the
serialkeepalive setting, the '\0' char triggers the connection to start
sending output.