use ruff for formatting #162
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@cursor review |
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.13"] | ||
| python-version: ["3.13"] |
There was a problem hiding this comment.
If we're gonna keep supporting 3.8, we should still make sure that it actually works, otherwise a dependency upgrade or using a new code feature could break 3.8 support and we'd miss it
There was a problem hiding this comment.
Or maybe this could be bumped up to 3.10 or 11 (would still eliminate all those "from typing" imports). I recall that this was supposed to support at least two versions behind current.
There was a problem hiding this comment.
Yeah, 3.8 is pretty old at this point and with uv it's easy to just use any version, even on older LTS systems
There was a problem hiding this comment.
I'll add multi-version testing in a follow up thanks!
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
Looks great! Not sure what was wrong with black, but I guess time have changed and ruff encompasses that anyway.
Get rid of black (not as bad as it looks)