Skip to content

Conversation

@mewwts
Copy link
Member

@mewwts mewwts commented Oct 2, 2025

Note

Renames async client methods to match sync API and introduces deprecated wrappers; updates internal calls and tests accordingly.

  • AsyncDuneClient API:
    • Rename core methods: execute -> execute_query, get_status -> get_execution_status, get_result -> get_execution_results, get_result_csv -> get_execution_results_csv.
    • Rename higher-level helpers: refresh -> run_query, refresh_csv -> run_query_csv, refresh_into_dataframe -> run_query_dataframe.
    • Add deprecated wrappers for old names (annotated with @deprecated) delegating to new methods.
    • Update internal flow: _refresh now uses execute_query and get_execution_status.
    • Adjust docstrings to reference new method names.
  • Tests:
    • Update e2e and unit tests to use new method names and mocks (run_query*, execute_query, get_execution_status).

Written by Cursor Bugbot for commit 9e9cd8f. This will update automatically on new commits. Configure here.

Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! Ya the async client was never really on the radar for the v1 release so it didn't get the close attention to detail.

@mewwts mewwts merged commit fbefedf into main Oct 2, 2025
2 checks passed
@mewwts mewwts deleted the async-api-match-sync branch October 2, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants