Skip to content

Add hdf5 capabilities#685

Closed
v1kko wants to merge 6 commits into
mainfrom
update
Closed

Add hdf5 capabilities#685
v1kko wants to merge 6 commits into
mainfrom
update

Conversation

@v1kko
Copy link
Copy Markdown
Contributor

@v1kko v1kko commented Dec 11, 2023

No description provided.

@stefsmeets
Copy link
Copy Markdown
Contributor

stefsmeets commented Dec 11, 2023

I'm working on code to write back to hdf5 atm, could we link this to imas2xarray?

See: duqtools/imas2xarray#12

@v1kko
Copy link
Copy Markdown
Contributor Author

v1kko commented Dec 11, 2023

That would solve the problem of IMAS just segfaulting when trying to open a HDF5 entry:

imas.DBEntry(imasdef.HDF5_BACKEND, self.db, self.shot, self.run, self.user) < this segfaults

So I am in favor of doing this via imas2xarray instead

@stefsmeets
Copy link
Copy Markdown
Contributor

The plan:

  • ImasHandle -> MDSPlusHandle (keep access through access layer), becomes legacy
  • New HD5Handle, goes to imas2xarray for loading the data
  • New way of operating on xarray (necessary to refactor on _apply_model)
  • ImasPath (user,machine,shot,run), direct path (pathlib.Path)

@stefsmeets stefsmeets marked this pull request as ready for review January 25, 2024 09:13
@stefsmeets
Copy link
Copy Markdown
Contributor

@v1kko Do you want to have a check before we merge this?

@stefsmeets
Copy link
Copy Markdown
Contributor

I'm closing this in favour of #706

@stefsmeets stefsmeets closed this Jan 25, 2024
@stefsmeets stefsmeets mentioned this pull request Jan 26, 2024
7 tasks
@stefsmeets stefsmeets deleted the update branch February 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants