Skip to content

Deprecate TilingComposite#577

Merged
randomir merged 4 commits intodwavesystems:masterfrom
randomir:deprecate-tiling-composite
Jun 5, 2025
Merged

Deprecate TilingComposite#577
randomir merged 4 commits intodwavesystems:masterfrom
randomir:deprecate-tiling-composite

Conversation

@randomir
Copy link
Copy Markdown
Member

@randomir randomir commented Jun 5, 2025

No description provided.

@randomir randomir marked this pull request as ready for review June 5, 2025 22:09
@randomir randomir force-pushed the deprecate-tiling-composite branch from d864c44 to 3122213 Compare June 5, 2025 22:10
@randomir randomir force-pushed the deprecate-tiling-composite branch from 3122213 to cb75244 Compare June 5, 2025 22:12
@randomir randomir requested a review from JoelPasvolsky June 5, 2025 22:14
Comment thread dwave/system/composites/tiling.py Outdated
@JoelPasvolsky
Copy link
Copy Markdown
Contributor

doctest failure is due to diff in lines 112 & 137:

>>> embedder_kwargs = {'max_num_embs': None}
>>> embedder_kwargs = {'max_num_emb': None, 'tile': tile}

one has an s and one does not

@randomir
Copy link
Copy Markdown
Member Author

randomir commented Jun 5, 2025

doctest failure is due to diff in lines 112 & 137:

>>> embedder_kwargs = {'max_num_embs': None}
>>> embedder_kwargs = {'max_num_emb': None, 'tile': tile}

one has an s and one does not

Good catch, thanks!

Fix docs refs in TilingComposite deprecation note

Fix doctest

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>
@randomir randomir force-pushed the deprecate-tiling-composite branch from 000eb11 to 7ce4305 Compare June 5, 2025 22:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (fe634db) to head (7ce4305).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   89.33%   86.88%   -2.46%     
==========================================
  Files          22       22              
  Lines        1988     1990       +2     
==========================================
- Hits         1776     1729      -47     
- Misses        212      261      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@randomir randomir merged commit 04fbebb into dwavesystems:master Jun 5, 2025
20 checks passed
@randomir randomir deleted the deprecate-tiling-composite branch June 5, 2025 23:04
@randomir randomir mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants