This repository was archived by the owner on Sep 24, 2025. It is now read-only.
Merged
Conversation
m3ller
approved these changes
Apr 10, 2020
randomir
reviewed
Apr 13, 2020
| name: linkcheck | ||
| command: | | ||
| . env/bin/activate | ||
| make -C docs/ linkcheck linkcheck_retries=3 linkcheck_anchors=False linkcheck_ignore=[https:\/\/codecov.*] |
Member
There was a problem hiding this comment.
Are you sure any of these options (linkcheck_retries, etc) actually propagate to sphinx-build?
Contributor
Author
There was a problem hiding this comment.
No. I put them here as a reminder of what might need to be set in other repos but when I tried setting more than a single value for linkcheck_ignore I could not get it to work properly. I did not finish work on that yet. Here I put this for PR to get feedback on whether we want to add this testing before I spend much time getting it to work
Member
There was a problem hiding this comment.
Oh, I think we should definitely add some link checking. Maybe even make it a periodic job. But finishing this PR would be a great start.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trial balloon: I used sphinx's linkcheck to find outdated links locally and am wondering whether I should add these to CircleCI. I'd first update all links in a repo, add the CircleCI test, and in the end add it to the SDK.
Let me know what you think.