Skip to content

Added support for colorings in Glasgow subgraph solver#272

Merged
boothby merged 6 commits intodwavesystems:mainfrom
boothby:glasgow-labels
Sep 11, 2025
Merged

Added support for colorings in Glasgow subgraph solver#272
boothby merged 6 commits intodwavesystems:mainfrom
boothby:glasgow-labels

Conversation

@boothby
Copy link
Copy Markdown
Collaborator

@boothby boothby commented Sep 5, 2025

  • updated Glasgow to latest version (with patches for c++17 support)
  • new parameters for subgraph.find_subgraph
    • as_embedding=True will produce a dict with tuple values
    • node_labels to be respected by GSS, node labels must match
    • edge_labels as with node_labels; directed edge labels match

* updated Glasgow to latest version (with patches for c++17 support)
* new parameters for subgraph.find_subgraph
  * as_embedding=True will produce a dict with tuple values
  * node_labels to be respected by GSS, node labels must match
  * edge_labels as with node_labels; directed edge labels match
@boothby boothby requested a review from thisac September 8, 2025 19:03
@boothby
Copy link
Copy Markdown
Collaborator Author

boothby commented Sep 8, 2025

failed test is unrelated to this ticket (and annoying)

Copy link
Copy Markdown
Contributor

@jackraymond jackraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Important and useful changes

Copy link
Copy Markdown
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boothby! Don't forget to add a release-notes entry (since we're now using reno for release-notes tracking).

Comment thread tests/test_subgraph.py
Comment thread minorminer/subgraph.pyx
Comment thread minorminer/subgraph.pyx Outdated
Comment thread minorminer/subgraph.pyx Outdated
Comment thread minorminer/subgraph.pyx Outdated
Comment thread minorminer/subgraph.pyx
Comment thread external/barrier
@boothby
Copy link
Copy Markdown
Collaborator Author

boothby commented Sep 11, 2025

Hold the phone, timeouts are working now?? I'm gonna add a test and see how that goes before merging.

@boothby boothby merged commit 2e43083 into dwavesystems:main Sep 11, 2025
34 checks passed
@boothby boothby deleted the glasgow-labels branch September 11, 2025 18:03
mahdiehmalekian pushed a commit to mahdiehmalekian/minorminer that referenced this pull request Nov 14, 2025
)

* Added support for colorings in Glasgow subgraph solver
* updated Glasgow to latest version (with patches for c++17 support)
* new parameters for subgraph.find_subgraph
  * as_embedding=True will produce a dict with tuple values
  * node_labels to be respected by GSS, node labels must match
  * edge_labels as with node_labels; directed edge labels match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants