This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix(deploy): ensure max retry count is set to 10 #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy doesnt respect max retry count, it is always set at 2 retries, as it was incorrectly set. The fix sets a max default of 10 with a break if earlier if the maxRetry is lower fixes #1262
azlam-abdulsalam
commented
Mar 9, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
=======================================
Coverage 62.11% 62.11%
=======================================
Files 61 61
Lines 2085 2085
Branches 439 439
=======================================
Hits 1295 1295
Misses 790 790 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JoeffreyChaucer
pushed a commit
to JoeffreyChaucer/sfpowerscripts
that referenced
this pull request
Mar 21, 2023
* fix(deploy): ensure max retry count is set to 10 deploy doesnt respect max retry count, it is always set at 2 retries, as it was incorrectly set. The fix sets a max default of 10 with a break if earlier if the maxRetry is lower fixes dxatscale#1262 * Increase time between retries to 30 seconds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy doesnt respect max retry count, it is always set at 2 retries, as it was incorrectly set. The
fix sets a max default of 10 with a break if earlier if the maxRetry is lower
fixes #1262
Checklist
All items have to be completed before a PR is merged