Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Conversation

@azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Apr 4, 2023

sfpowerscripts skip unlocked packages in the org by
matching Package Version Ids. This is done by matching the
length of package versions. It should be 15 characters
instead of the 14 characters

fix #1284

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

sfpowerscripts skip unlocked packages in the org by
matching Package Version Ids. This is done by matching the
length of package versions. It should be 15 characters
instead of the 14 characters

fix #1284
@reviewpad
Copy link

reviewpad bot commented Apr 4, 2023

AI-Generated Pull Request Summary: This pull request addresses a bug in the InstallUnlockedPackageCollection, where the length of package version IDs used for matching was incorrect. The length has been updated from 14 to 15 characters, ensuring that sfpowerscripts can correctly skip unlocked packages in the org. This change is made in a single file, with one line of code modified. The issue fixed is #1284.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 4, 2023
@reviewpad reviewpad bot requested a review from gnemiq April 4, 2023 23:51
@azlam-abdulsalam azlam-abdulsalam merged commit 1e798cf into main Apr 5, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the 1284-intall-external-unlocked-multiple-package-with-same-begining branch April 5, 2023 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

small Pull request is small waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intall external Unlocked : multiple package with same begining

3 participants