Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Conversation

@azlam-abdulsalam
Copy link
Contributor

fix #1294

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@azlam-abdulsalam azlam-abdulsalam linked an issue Apr 19, 2023 that may be closed by this pull request
@reviewpad
Copy link

reviewpad bot commented Apr 19, 2023

AI-Generated Summary: This pull request introduces a change to the InstallSourcePackageImpl.ts file to address issue #1294. With this update, the validate command will no longer display deployment options by adding a conditional statement that only prints the deployment options when the isInstallingForValidation option is not set.

@reviewpad reviewpad bot requested a review from gnemiq April 19, 2023 13:50
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e798cf) 61.17% compared to head (3b76f04) 61.17%.

❗ Current head 3b76f04 differs from pull request most recent head dffe203. Consider uploading reports for the commit dffe203 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   61.17%   61.17%           
=======================================
  Files          61       61           
  Lines        2117     2117           
  Branches      434      443    +9     
=======================================
  Hits         1295     1295           
+ Misses        822      770   -52     
- Partials        0       52   +52     

see 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vuha-acn vuha-acn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@azlam-abdulsalam azlam-abdulsalam merged commit 66834fb into main Apr 24, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the 1294-disable-display-of-deployment-options-during-validate branch April 24, 2023 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

small Pull request is small waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable display of deployment options during validate

3 participants