Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Conversation

@nvuillam
Copy link
Contributor

@nvuillam nvuillam commented Sep 3, 2023

Summary generated by Reviewpad on 03 Sep 23 16:05 UTC

This pull request arranges the badges in the README.md file and deprecates a broken one. The changes include adding version and download count badges, updating the GitHub stars and contributors badges, and adding a license badge. Additionally, the pull request reorders the badges and removes one unrelated badge.

Result:

image

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot requested a review from azlam-abdulsalam September 3, 2023 16:05
@reviewpad
Copy link

reviewpad bot commented Sep 3, 2023

Thank you @nvuillam for this first contribution!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Sep 3, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 3, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Arrange badges and deprecate broken one :)' (1631c48)
  • Unconventional title detected: 'Arrange badges and deprecate broken one :)' illegal 'A' character in commit message type: col=00

⚠️ Warnings

  • Please link an issue to the pull request

@azlam-abdulsalam
Copy link
Contributor

Thanks @nvuillam .

Lets remove the downloads one, as it only shows the npm downloads, most projects use sfpowerscripts as docker image, and I don't think there is a GitHub badge yet

https://github.com/dxatscale/sfpowerscripts/pkgs/container/sfpowerscripts

@nvuillam
Copy link
Contributor Author

nvuillam commented Sep 3, 2023

I never found a badge or even an API to get the number of docker pulls of a ghcr.io image... if you find some plz notify me ;)

@nvuillam
Copy link
Contributor Author

nvuillam commented Sep 3, 2023

But u should keep the downloads/week one as you have great stats 😎

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (438f9ba) 46.91% compared to head (ac8d991) 46.91%.

❗ Current head ac8d991 differs from pull request most recent head ab2fe79. Consider uploading reports for the commit ab2fe79 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files          70       70           
  Lines        2656     2656           
  Branches      309      309           
=======================================
  Hits         1246     1246           
  Misses       1408     1408           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam
Copy link
Contributor

Apparently shields haven't implemented badges for ghcr 😭

@nvuillam
Copy link
Contributor Author

nvuillam commented Sep 3, 2023

It requires rights on the GitHub package to get donwload stats... I'll probably make a little utility someday to automate badge creation from the own repo CI :)

@azlam-abdulsalam
Copy link
Contributor

May be we should have a badge for github downloads in a static manner, so that actual number is being displayed

@azlam-abdulsalam azlam-abdulsalam merged commit 7c3e533 into dxatscale:main Sep 4, 2023
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks once again @nvuillam

@nvuillam
Copy link
Contributor Author

nvuillam commented Sep 4, 2023

May be we should have a badge for github downloads in a static manner, so that actual number is being displayed

That's what I'll automate someday if nobody does it before ^^

@nvuillam nvuillam deleted the patch-1 branch September 4, 2023 05:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants