-
Notifications
You must be signed in to change notification settings - Fork 111
Arrange badges and deprecate broken one :) #1401
Conversation
|
Thank you @nvuillam for this first contribution! |
|
Reviewpad Report
|
|
Thanks @nvuillam . Lets remove the downloads one, as it only shows the npm downloads, most projects use sfpowerscripts as docker image, and I don't think there is a GitHub badge yet https://github.com/dxatscale/sfpowerscripts/pkgs/container/sfpowerscripts |
|
I never found a badge or even an API to get the number of docker pulls of a ghcr.io image... if you find some plz notify me ;) |
|
But u should keep the downloads/week one as you have great stats 😎 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 46.91% 46.91%
=======================================
Files 70 70
Lines 2656 2656
Branches 309 309
=======================================
Hits 1246 1246
Misses 1408 1408
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Apparently shields haven't implemented badges for ghcr 😭 |
|
It requires rights on the GitHub package to get donwload stats... I'll probably make a little utility someday to automate badge creation from the own repo CI :) |
|
May be we should have a badge for github downloads in a static manner, so that actual number is being displayed |
azlam-abdulsalam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks once again @nvuillam
That's what I'll automate someday if nobody does it before ^^ |
Summary generated by Reviewpad on 03 Sep 23 16:05 UTC
This pull request arranges the badges in the README.md file and deprecates a broken one. The changes include adding version and download count badges, updating the GitHub stars and contributors badges, and adding a license badge. Additionally, the pull request reorders the badges and removes one unrelated badge.
Result:
Checklist
All items have to be completed before a PR is merged