Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

Conversation

@rody
Copy link
Contributor

@rody rody commented Sep 15, 2023

Summary generated by Reviewpad on 15 Sep 23 03:39 UTC

This pull request includes three patches.

Patch 1/3 updates the base image from salesforce/cli:2.5.8-full to node:20-bookworm and removes the unused cache from npm and yarn. It also installs the necessary dependencies for the bundled version of Chromium that Puppeteer uses.

Patch 2/3 updates the debian base during installation by upgrading to the latest version and installing git, curl, and sudo.

Patch 3/3 further updates the base image from node:20-bookworm to ubuntu:22.04 and installs additional dependencies like chromium-bsu and gnupg. It also installs Node.js via nodesource and installs yarn.

Overall, these patches update the base image, add and remove dependencies, and optimize the installation process.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Sep 15, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 15, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'use node:20 and remove unused cache from npm and yarn' (e018ce3)
  • Unconventional commit detected: 'update debian base during installation' (a899fb3)
  • Unconventional commit detected: 'use ubuntu as the base image' (0386c9f)
  • Unconventional title detected: 'Bugfix/use lower uid in dockerfiles' illegal 'g' character in commit message type: col=02

⚠️ Warnings

  • Please link an issue to the pull request

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8de5d1c) 46.87% compared to head (0b316a5) 46.87%.

❗ Current head 0b316a5 differs from pull request most recent head 0386c9f. Consider uploading reports for the commit 0386c9f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1409   +/-   ##
=======================================
  Coverage   46.87%   46.87%           
=======================================
  Files          70       70           
  Lines        2658     2658           
  Branches      308      308           
=======================================
  Hits         1246     1246           
  Misses       1384     1384           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam azlam-abdulsalam merged commit 78739d5 into main Sep 15, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the bugfix/use_lower_uid_in_dockerfiles branch September 15, 2023 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

medium Pull request is medium waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants