Skip to content

Types for Accordion Group #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 1 commit into from
Feb 3, 2022
Merged

Types for Accordion Group #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions ...operties/accordion-group-table-properties/accordion-group-table-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
<td>If true, the component will be disabled.</td>
</tr>
<tr>
<td>onActiveChange: function</td>
<td>onActiveChange: EventEmitter</td>
<td></td>
<td>
This function will be called when the user clicks on an accordion. The
index of the clicked accordion will be passed as a parameter.
This event will emit in case the user clicks on an accordion. The index of
the clicked accordion will be passed as a parameter.
</td>
</tr>
<tr>
Expand Down Expand Up @@ -85,13 +85,6 @@
label.
</td>
</tr>
<tr>
<td>iconPosition: 'before' | 'after'</td>
<td>
<code>'before'</code>
</td>
<td>Whether the icon should appear after or before the label.</td>
</tr>
<tr>
<td>assistiveText: string</td>
<td></td>
Expand Down
51 changes: 40 additions & 11 deletions projects/dxc-ngx-cdk/src/lib/dxc-accordionGroup/dxc-accordionGroup.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,49 @@ import {
coerceBooleanProperty,
} from "@angular/cdk/coercion";

type Space =
| "xxsmall"
| "xsmall"
| "small"
| "medium"
| "large"
| "xlarge"
| "xxlarge";

type Margin = {
top?: Space;
bottom?: Space;
left?: Space;
right?: Space;
};

@Component({
selector: "dxc-accordion-group",
templateUrl: "./dxc-accordionGroup.component.html",
providers: [CssUtils, AccordionService],
})
export class DxcAccordionGroupComponent implements OnChanges, OnInit {
@Input() margin: any;
/**
* Size of the margin to be applied to the component ('xxsmall' | 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
* You can pass an object with 'top', 'bottom', 'left' and 'right' properties in order to specify different margin sizes.
*/
@Input() margin: Space | Margin;
/**
* The index of the active accordion. If undefined, the component will be uncontrolled and the active accordion will be managed internally by the component.
* If null, the component will be controlled and all accordions will be closed.
*/
@Input()
get indexActive(): any {
get indexActive(): number {
return this._indexActive;
}
set indexActive(value: any) {
if (value === undefined || value === "undefined") {
this._indexActive = undefined;
} else if (value === null || value === "null") {
this._indexActive = null;
} else {
this._indexActive = coerceNumberProperty(value);
}
set indexActive(value: number) {
if (value == null) this._indexActive = value;
else this._indexActive = coerceNumberProperty(value);
}
private _indexActive;
/**
* If true, the component will be disabled.
*/
@Input()
get disabled(): boolean {
return this._disabled;
Expand All @@ -52,10 +74,17 @@ export class DxcAccordionGroupComponent implements OnChanges, OnInit {
this._disabled = coerceBooleanProperty(value);
}
private _disabled = false;
@Output() onActiveChange = new EventEmitter<any>();
/**
* This event will emit in case the user clicks on an accordion.
* The index of the clicked accordion will be passed as a parameter.
*/
@Output() onActiveChange: EventEmitter<number> = new EventEmitter<number>();

@HostBinding("class") className;

/**
* Customized accordion that allows this accordion group component. Accordion component can be checked here.
*/
@ContentChildren(DxcAccordionComponent)
dxcAccordion: QueryList<DxcAccordionComponent>;

Expand Down