Skip to content

[Patch] Card outlined prop default value #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidamag merged 1 commit into from
Feb 10, 2022
Merged

[Patch] Card outlined prop default value #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nents/examples/card/properties/card-table-properties/card-table-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
</tr>
<tr>
<td>outlined: boolean</td>
<td><code>false</code></td>
<td><code>true</code></td>
<td>Whether the card must be outlined.
</td>
</tr>
Expand Down
6 changes: 3 additions & 3 deletions projects/dxc-ngx-cdk/src/lib/dxc-card/dxc-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export class DxcCardComponent implements OnInit {
/**
* Whether the card must be outlined.
*/
@Input() outlined: boolean = false;
@Input() outlined: boolean = true;

private isHovered: boolean;

Expand All @@ -136,7 +136,7 @@ export class DxcCardComponent implements OnInit {
imageCover: false,
margin: null,
tabIndexValue: 0,
outlined: false,
outlined: true,
});

public ngOnChanges(changes: SimpleChanges): void {
Expand Down Expand Up @@ -195,7 +195,7 @@ export class DxcCardComponent implements OnInit {
}

getShadowDepth() {
return this.defaultInputs.value.outlined
return !this.defaultInputs.value.outlined
? "0"
: this.isHovered &&
this.onClick.observers.length > 0 &&
Expand Down