Skip to content

Adding tests to the radio group #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidamag merged 3 commits into from
Mar 24, 2022
Merged

Adding tests to the radio group #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ffdc33
Adding tests to the radio group
Jialecl Mar 23, 2022
e86c611
Merge branch 'master' of https://github.com/dxc-technology/halstack-a…
Jialecl Mar 23, 2022
eef1bc4
removing console.log
Jialecl Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-cdk-site/src/app/pages/theme-builder/previews/radio-preview/radio-preview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
[options]="options"
label="Uncontrolled radio"
helperText="example helper text"
[optional]="true"
stacking="row"
(onBlur)="handleOnBlur($event)"
></dxc-radio-group>
<dxc-radio-group
[options]="options"
Expand Down
6 changes: 5 additions & 1 deletion ...gx-cdk-site/src/app/pages/theme-builder/previews/radio-preview/radio-preview.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ export class RadioPreviewComponent implements OnInit {

value = "";
handleOnChange($event) {
//this.value = $event;
this.value = $event;
}

handleOnBlur($event) {
console.log($event);
}

onChange1(event) {
Expand Down
245 changes: 244 additions & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-radio-group/dxc-radio-group.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,250 @@
import { render, fireEvent } from "@testing-library/angular";
import { render, fireEvent, screen } from "@testing-library/angular";
import userEvent from "@testing-library/user-event";
import { DxcRadioGroupComponent } from "./dxc-radio-group.component";
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from "@angular/platform-browser-dynamic/testing";
import { TestBed } from "@angular/core/testing";
import { DxcRadioGroupModule } from "./dxc-radio-group.module";

TestBed.initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);

const options = [
{ value: "1", label: "label1", disabled: false },
{ value: "2", label: "label2", disabled: true },
{ value: "3", label: "label3", disabled: true },
{ value: "4", label: "label4", disabled: false },
];

describe("DxcRadioGroup tests", () => {
test("should render dxc-radio-group", async () => {
const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: { label: "test-radio-group", options: options },
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

expect(dxcRadioGroup.getByText("test-radio-group"));
expect(dxcRadioGroup.getByText("label1"));
expect(dxcRadioGroup.getByText("label2"));
expect(dxcRadioGroup.getByText("label3"));
expect(dxcRadioGroup.getByText("label4"));
});

test("dxc-radio-group should render optional item", async () => {
const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: { label: "test-radio-group", options: options, optional: true },
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});
expect(dxcRadioGroup.getByText("(Optional)"));
expect(dxcRadioGroup.getByText("label1"));
expect(dxcRadioGroup.getByText("label2"));
expect(dxcRadioGroup.getByText("label3"));
expect(dxcRadioGroup.getByText("label4"));
expect(dxcRadioGroup.getByText("N/A"));
});

test("dxc-radio-group should render optional item with custom label", async () => {
const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: { label: "test-radio-group", options: options, optional: true, optionalItemLabel: "optional item" },
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

expect(dxcRadioGroup.getByText("label1"));
expect(dxcRadioGroup.getByText("label2"));
expect(dxcRadioGroup.getByText("label3"));
expect(dxcRadioGroup.getByText("label4"));
expect(dxcRadioGroup.getByText("optional item"));
});

test("dxc-radio-group shoul render error message", async () => {
const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
error: "Error message",
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

expect(dxcRadioGroup.getByText("Error message"));
});

test("dxc-radio-group should change value when uncontrolled", async () => {
const changeMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
onChange: {
emit: changeMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

fireEvent.click(dxcRadioGroup.getByText("label1"));
expect(changeMock).toHaveBeenCalledWith("1");
expect(screen.getAllByRole("radio")[0].getAttribute("aria-checked")).toBe(
"true"
);
});

test("dxc-radio-group should not change value when controlled", async () => {
const changeMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
value: "1",
onChange: {
emit: changeMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

fireEvent.click(dxcRadioGroup.getByText("label4"));
expect(changeMock).toHaveBeenCalledWith("4");
expect(screen.getAllByRole("radio")[0].getAttribute("aria-checked")).toBe(
"true"
);
expect(screen.getAllByRole("radio")[3].getAttribute("aria-checked")).toBe(
"false"
);
});

test("dxc-radio-group click on disabled should not emit", async () => {
const changeMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
value: "1",
onChange: {
emit: changeMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

fireEvent.click(dxcRadioGroup.getByText("label2"));
fireEvent.click(dxcRadioGroup.getByText("label3"));
expect(screen.getAllByRole("radio")[0].getAttribute("aria-checked")).toBe(
"true"
);
expect(screen.getAllByRole("radio")[1].getAttribute("aria-checked")).toBe(
"false"
);
expect(screen.getAllByRole("radio")[2].getAttribute("aria-checked")).toBe(
"false"
);
expect(changeMock).toBeCalledTimes(0);
});

test("dxc-radio-group click on readOnly should not emit", async () => {
const changeMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
value: "1",
readOnly: true,
onChange: {
emit: changeMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

fireEvent.click(dxcRadioGroup.getByText("label2"));
fireEvent.click(dxcRadioGroup.getByText("label3"));
fireEvent.click(dxcRadioGroup.getByText("label4"));
expect(screen.getAllByRole("radio")[0].getAttribute("aria-checked")).toBe(
"true"
);
expect(screen.getAllByRole("radio")[1].getAttribute("aria-checked")).toBe(
"false"
);
expect(screen.getAllByRole("radio")[2].getAttribute("aria-checked")).toBe(
"false"
);
expect(screen.getAllByRole("radio")[3].getAttribute("aria-checked")).toBe(
"false"
);
expect(changeMock).toBeCalledTimes(0);
});

test("dxc-radio-group keyboard events", async () => {
const changeMock = jest.fn((x) => {});
const blurMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
onChange: {
emit: changeMock,
} as any,
onBlur: {
emit: blurMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

userEvent.tab();
expect(changeMock).toHaveBeenCalledTimes(0);
userEvent.keyboard(" ");
expect(changeMock).toHaveBeenCalledWith("1");
userEvent.keyboard("{ArrowUp}");
expect(changeMock).toHaveBeenCalledWith("4");
dxcRadioGroup.detectChanges();
expect(screen.getAllByRole("radio")[3].getAttribute("aria-checked")).toBe(
"true"
);
userEvent.tab();
expect(blurMock).toHaveBeenCalledWith({value: "4" , error: undefined});
});

test("dxc-radio-group onBlur event", async () => {
const changeMock = jest.fn((x) => {});
const blurMock = jest.fn((x) => {});

const dxcRadioGroup = await render(DxcRadioGroupComponent, {
componentProperties: {
label: "test-radio-group",
options: options,
onChange: {
emit: changeMock,
} as any,
onBlur: {
emit: blurMock,
} as any,
},
excludeComponentDeclaration: true,
imports: [DxcRadioGroupModule],
});

userEvent.tab();
expect(changeMock).toHaveBeenCalledTimes(0);
userEvent.tab();
expect(blurMock).toHaveBeenCalledWith({value: undefined , error: "This is required"});
});
});
3 changes: 1 addition & 2 deletions projects/dxc-ngx-cdk/src/lib/dxc-radio-group/dxc-radio-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,8 @@ export class DxcRadioGroupComponent implements OnInit {
this.indexToFocus = 0;
}
this.service.firstTabbedFocus = false;
} else {
const errorMessage =
(!this.value || this.value !== "") && !this.optional
!(this.value || this.value === "") && !this.optional
? "This is required"
: undefined;
this.onBlur.emit({ value: this.value, error: errorMessage });
Expand Down