Skip to content

[Minor] Added prop type in button component #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 1 commit into from
Apr 6, 2022
Merged

[Minor] Added prop type in button component #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...examples/button/properties/button-table-properties/button-table-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@
</td>
<td>Uses on of the available button modes.</td>
</tr>
<tr>
<td>type: 'button' | 'reset' | 'submit'</td>
<td>
<code>'button'</code>
</td>
<td>This prop corresponds to the 'type' prop of the button in html.</td>
</tr>
<tr>
<td>label: string</td>
<td></td>
Expand Down
11 changes: 9 additions & 2 deletions projects/dxc-ngx-cdk/src/lib/dxc-button/dxc-button.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<button class="dxcButton" disableRipple mat-button [disabled]="disabled" (click)="onClickHandler($event)"
[tabindex]="disabled ? -1 : tabIndexValue">
<button
class="dxcButton"
[type]="type"
disableRipple
mat-button
[disabled]="disabled"
(click)="onClickHandler($event)"
[tabindex]="disabled ? -1 : tabIndexValue"
>
<img src="{{ iconSrc }}" *ngIf="iconSrc" />
<ng-content select="dxc-button-icon"></ng-content>
<span *ngIf="label">{{ label }}</span>
Expand Down
4 changes: 4 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-button/dxc-button.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ export class DxcButtonComponent {
* Size of the component.
*/
@Input() size: Size = "fitContent";
/**
* This prop corresponds to the 'type' prop of the button in html.
*/
@Input() type: "reset" | "submit" | "button" = "button";
/**
* Value of the tabindex attribute.
*/
Expand Down