Skip to content

Adding type file to appLayout sidenav #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidamag merged 1 commit into from
Apr 6, 2022
Merged

Adding type file to appLayout sidenav #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions ...ication-layout/dxc-application-layout-sidenav/dxc-application-layout-sidenav.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,11 @@ import { CssUtils } from "../../utils";
import { responsiveSizes } from "../../variables";
import { coerceBooleanProperty } from "@angular/cdk/coercion";
import { SidenavService } from "./services/sidenav.service";

type Space =
| "xxsmall"
| "xsmall"
| "small"
| "medium"
| "large"
| "xlarge"
| "xxlarge";

type Padding = {
top?: Space;
bottom?: Space;
left?: Space;
right?: Space;
};
import {
ApplicationLayoutSidenavProperties,
Space,
Spacing,
} from "./dxc-application-layout-sidenav.types";

@Component({
selector: "dxc-application-layout-sidenav",
Expand All @@ -49,7 +38,7 @@ export class DxcApplicationLayoutSidenavComponent implements OnInit, OnChanges {
* Size of the padding to be applied to the custom area ('xxsmall' | 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
* You can pass an object with 'top', 'bottom', 'left' and 'right' properties in order to specify different padding sizes.
*/
@Input() padding: Space | Padding;
@Input() padding: Space | Spacing;
/**
* If false, the arrow button is hidden.
* In lower resolutions the arrow will be always displayed.
Expand All @@ -68,9 +57,10 @@ export class DxcApplicationLayoutSidenavComponent implements OnInit, OnChanges {
isResponsive = true;
isShown: boolean;

defaultInputs = new BehaviorSubject<any>({
defaultInputs = new BehaviorSubject<ApplicationLayoutSidenavProperties>({
displayArrow: true,
padding: null,
mode: "overlay",
});

@ViewChild("sidenavContainer", { static: false }) sidenav: ElementRef;
Expand Down
21 changes: 21 additions & 0 deletions ...application-layout/dxc-application-layout-sidenav/dxc-application-layout-sidenav.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
export type Space =
| "xxsmall"
| "xsmall"
| "small"
| "medium"
| "large"
| "xlarge"
| "xxlarge";

export type Spacing = {
top?: Space;
bottom?: Space;
left?: Space;
right?: Space;
};

export interface ApplicationLayoutSidenavProperties {
mode?: "push" | "overlay";
padding?: Space | Spacing;
displayArrow?: boolean;
}