Skip to content

Added types file in dropdwon #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 1 commit into from
Apr 6, 2022
Merged

Added types file in dropdwon #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions projects/dxc-ngx-cdk/src/lib/dxc-dropdown/dxc-dropdown.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,7 @@ import {
coerceNumberProperty,
} from "@angular/cdk/coercion";
import { DropdownService } from "./services/dropdown.service";

type Space =
| "xxsmall"
| "xsmall"
| "small"
| "medium"
| "large"
| "xlarge"
| "xxlarge";

type Margin = {
top?: Space;
bottom?: Space;
left?: Space;
right?: Space;
};
import { DropdownProperties, Space, Spacing } from "./dxc-dropdown.types";

@Component({
selector: "dxc-dropdown",
Expand Down Expand Up @@ -79,11 +64,11 @@ export class DxcDropdownComponent implements OnChanges {

/**
* Size of the margin to be applied to the component
* ('xxsmall' | 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
* You can pass an object with 'top', 'bottom', 'left' and 'right' properties
* ('xxsmall' | 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
* You can pass an object with 'top', 'bottom', 'left' and 'right' properties
* in order to specify different margin sizes.
*/
@Input() margin: Space | Margin;
@Input() margin: Space | Spacing;

/**
* Size of the component.
Expand Down Expand Up @@ -151,9 +136,8 @@ export class DxcDropdownComponent implements OnChanges {
menuOptions: string;
triggerStyles: string;

defaultInputs = new BehaviorSubject<any>({
defaultInputs = new BehaviorSubject<DropdownProperties>({
optionsIconPosition: "before",
iconSrc: null,
iconPosition: "before",
label: null,
name: null,
Expand Down
28 changes: 28 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-dropdown/dxc-dropdown.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
export interface DropdownProperties {
margin?: Space | Spacing;
optionsIconPosition?: "before" | "after";
iconPosition?: "before" | "after";
label?: string;
name?: string;
caretHidden?: boolean;
size?: "small" | "medium" | "large" | "fillParent" | "fitContent";
tabIndexValue?: number;
expandOnHover?: boolean;
disabled?: boolean;
}

export type Space =
| "xxsmall"
| "xsmall"
| "small"
| "medium"
| "large"
| "xlarge"
| "xxlarge";

export type Spacing = {
top?: Space;
bottom?: Space;
left?: Space;
right?: Space;
};