Skip to content

Conversation

@lcordobapuerto
Copy link
Collaborator

@lcordobapuerto lcordobapuerto commented Jan 15, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
To change the value of the token assigned to spinner component.

Description
In the Specs of the Spinner component, it is described that the font-weight of the percentage is 600, which is not correct, as it is 700. The token displayed for that font-weight is correct once we change that value, as font-bold sets font weight as bold (700).

Screenshots

Spinner typography specs halstack-typography-tokens

@GomezIvann GomezIvann self-requested a review January 15, 2024 11:50
@GomezIvann GomezIvann self-assigned this Jan 15, 2024
@GomezIvann
Copy link
Collaborator

Great job Lara! 🚀

@GomezIvann GomezIvann merged commit f2972a2 into master Jan 15, 2024
@GomezIvann GomezIvann deleted the lcordobapuerto/spinner-specs branch January 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants