Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 2, 2024

Checklist
(Check off all the items before submitting)

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Live examples have been updated. Now they use our toast and the code has been improved.
  • Added release 14 to the releases page.
  • Contextual Menu. Improved DOM tree structure. Also, tried to add the Tooltip. In a future PR we will make the tooltip work in this scenarios where there's an extra container.

Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following disabledRules in packages/lib/test/accessibility/rules/specific/contextual-menu/disabledRules.js that are not covered by this solution:

  • "aria-required-children": I think this is caused by a ul being a direct child of another ul. The following structure is expected instead:
<ul>
  <li>
    <ul>
      ...
    </ul>
  </li>
</ul>
  • "aria-required-parent": There is a menuitem whose parent is not a ``
  • "list": A list element has children with the role menuitem, which is not allowed as it is expected to be a listitem

After doing the appropiate changes to the roles, don't forget to swap the functional test checks accordingly.

@GomezIvann GomezIvann marked this pull request as ready for review October 3, 2024 09:46
@Mil4n0r Mil4n0r self-requested a review October 7, 2024 10:42
@Mil4n0r Mil4n0r merged commit d25aef4 into master Oct 7, 2024
@Mil4n0r Mil4n0r deleted the gomezivann/contextual-menu-updates branch October 7, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants