Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Oct 4, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
A clear description of the purpose of the change. Applicable in case this change is not linked to an issue.

Description
The following problems have been addressed:

  • Adding the possibility to sort any kind of component based on any criteria.
  • Add the possibility to paginate the DataGrid component.
  • Fixed the unwanted behavior for draggable columns along with expandable content (When expanding or collapsing the content, the column order would roll back to the initial status)
  • Fixed unwanted behavior when toggling a grandchild shown in this quick video:
    grandchild-toggle-demo.webm

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Oct 4, 2024

I would like to add many edge cases to both functional and visual tests, I also have to tidy up the current tests that I added.

I also have to update the API with all the documentation required for pagination and the sorting strategy.

@Mil4n0r Mil4n0r changed the title Mil4n0r/fix datagrid DataGrid improvements Oct 7, 2024
@Mil4n0r Mil4n0r marked this pull request as ready for review October 9, 2024 08:26
@Mil4n0r Mil4n0r requested a review from Jialecl October 9, 2024 08:29
@Jialecl Jialecl merged commit 718e29e into master Oct 21, 2024
@Jialecl Jialecl deleted the Mil4n0r/fix_datagrid branch October 21, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants