Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 9, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Added a tooltip to long options with ellipses in the Contextual Menu.
  • A tooltip was added to the Select component. Now our tooltip appears in long option labels and long selected values
  • Updated tooltip implementation in our internal components. Now our tooltip doesn't add an extra container inside of our components.
  • Added new title prop to the Dropdown component.
  • Added new storybook tests to check all this functionality.

@GomezIvann GomezIvann marked this pull request as ready for review October 11, 2024 07:06
@Mil4n0r
Copy link
Collaborator

Mil4n0r commented Oct 14, 2024

I have been unable to find the reason why certain tooltips are not being displayed in the Chromatic's snapshots meanwhile they are visible in local storybook...

@Mil4n0r Mil4n0r self-requested a review October 15, 2024 08:32
@Mil4n0r Mil4n0r merged commit e3347c0 into master Oct 15, 2024
@Mil4n0r Mil4n0r deleted the gomezivann/tooltip-updates branch October 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants