Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Nov 19, 2024

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Using the injectStyles flag of tsup, we can add CSS styles to the Halstack build. I took advantage of that to import the Material Icons into our build, so that our components can have them by default, without needing to use HalstackProvider. This is an improvement on the current approach.

@GomezIvann GomezIvann marked this pull request as ready for review November 19, 2024 08:58
@Jialecl Jialecl self-requested a review November 19, 2024 08:58
@Jialecl Jialecl self-assigned this Nov 19, 2024
@Jialecl Jialecl merged commit 355b1d4 into master Nov 20, 2024
2 checks passed
@Jialecl Jialecl deleted the gomezivann/imports-fixed branch November 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants