Skip to content

Conversation

@PelayoFelgueroso
Copy link
Collaborator

…it's controlled

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Closes

@PelayoFelgueroso PelayoFelgueroso changed the title Fix active tab visibility when activeTab is modified externally when … Fix active tab visibility when activeTab is modified externally Nov 18, 2025
@Jialecl Jialecl self-requested a review November 18, 2025 10:32
@Jialecl Jialecl self-assigned this Nov 18, 2025
@Jialecl
Copy link
Collaborator

Jialecl commented Nov 18, 2025

This is too complicated instead it can be fixed just by adding activeTabId to the dependency list of the useEffect.

@Jialecl Jialecl merged commit b08b8e8 into master Nov 18, 2025
5 checks passed
@Jialecl Jialecl deleted the PelayoFelgueroso/tabs-visibility branch November 18, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants