Skip to content

Conversation

@snim2
Copy link
Contributor

@snim2 snim2 commented Aug 21, 2025

This is a breaking change which removes support for versions of PHP less than 8.

Resolves: https://...

  • Includes tests (if new features are introduced)
  • Commit message includes link to the ticket/issue
  • Changelog updated
  • [-] PR open against dxw's Homebrew Tap to point the Whippet formula to the new version number

@RobjS
Copy link
Contributor

RobjS commented Aug 21, 2025

I think the theoretical view of PHP version bumps is that they aren't breaking changes, see e.g. https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html#why-dropping-php-support-in-a-minor-version-is-not-a-bc-break

But I've also seen people complain when PHP bumps have been treated like that, and it did end up breaking things.

I'm of two minds here; my general preference would be to be on the safe side and make it a major version bump. However, every single project we have references Whippet v2 in its root composer.json (and uses that Composer file to install Whippet in CI), so we'll have to bump each of those individually if we make this a major version release.

@snim2
Copy link
Contributor Author

snim2 commented Aug 21, 2025

I think the theoretical view of PHP version bumps is that they aren't breaking changes, see e.g. https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html#why-dropping-php-support-in-a-minor-version-is-not-a-bc-break

But I've also seen people complain when PHP bumps have been treated like that, and it did end up breaking things.

I'm of two minds here; my general preference would be to be on the safe side and make it a major version bump. However, every single project we have references Whippet v2 in its root composer.json (and uses that Composer file to install Whippet in CI), so we'll have to bump each of those individually if we make this a major version release.

That's a good point. OK, I'll force-push a minor version release.

This release removes support for PHP versions 7.4
and below.

In practice we have run the code here on a mixture
of PHP versions without issue.
@snim2 snim2 force-pushed the chore/release-v3.0.0 branch from 9c64d83 to 1ec19bc Compare August 21, 2025 16:05
@snim2 snim2 changed the title Release v3.0.0 Release v2.7.0 Aug 21, 2025
@snim2 snim2 merged commit eb8c8e2 into main Aug 22, 2025
6 of 7 checks passed
@snim2 snim2 deleted the chore/release-v3.0.0 branch August 22, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants