Skip to content

update bindgen dependency #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zshipko merged 2 commits into from
Dec 3, 2024
Merged

update bindgen dependency #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c9960
update bindgen
bhelx Dec 3, 2024
d41f6f2
fix: handle int64 type and untyped objects
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"typescript": "^5.3.2"
},
"dependencies": {
"@dylibso/xtp-bindgen": "1.0.0-rc.13",
"@dylibso/xtp-bindgen": "1.0.0-rc.16",
"ejs": "^3.1.10"
}
}
10 changes: 8 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ function toPythonTypeX(type: XtpNormalizedType): string {
return opt('str');
case 'int32':
return opt('int');
case 'int64':
return opt('int');
case 'float':
return opt('float');
case 'double':
Expand All @@ -49,11 +51,15 @@ function toPythonTypeX(type: XtpNormalizedType): string {
// TODO: improve typing of dicts
return opt('dict');
case 'object':
return opt(pythonTypeName((type as ObjectType).name));
const name = (type as ObjectType).name;
if (!name) {
return opt('dict');
}
return opt(pythonTypeName(name));
case 'enum':
return opt(pythonTypeName((type as EnumType).name));
default:
throw new Error("Can't convert XTP type to Python type: " + type)
throw new Error("Can't convert XTP type to Python type: " + JSON.stringify(type))
}
}

Expand Down