fix/ci: install instructions, build with latest js-pdk#28
Conversation
|
Is there potentially another layer this could be fixed at, like in the CLI so that it doesn't entirely exit, or maybe checks these dependencies listed after the prepare script? The way I read this PR is that we now won't report the deps missing as part of our diagnosis. Could be misreading though! |
|
We could change the cli to check the deps section after. However, it would be redundant as the prepare script checks and reports if they are missing. In https://github.com/dylibso/xtp/pull/994#discussion_r1927155042 @bhelx mentioned that the dependencies section was deprecated in favor of the prepare script and I see the When |
Having the
dependenciessection in the yaml, when a dependency is missing, prevents the prepare script from running and displaying a more helpful error message.