Update scopes parameter name in settings.py#109
Merged
Dynatrace-James-Kitson merged 1 commit intodynatrace-oss:mainfrom Jan 14, 2025
Merged
Update scopes parameter name in settings.py#109Dynatrace-James-Kitson merged 1 commit intodynatrace-oss:mainfrom
Dynatrace-James-Kitson merged 1 commit intodynatrace-oss:mainfrom
Conversation
Fix scopes parameter towards API call
|
|
|
Dynatrace-James-Kitson
approved these changes
Jan 14, 2025
Collaborator
Dynatrace-James-Kitson
left a comment
Dynatrace-James-Kitson
left a comment
There was a problem hiding this comment.
Looks good, thank you. Will have new release shortly.
Collaborator
|
FYI @Dynatrace-Jeroen-Hautekeete, @Dynatrace-James-Kitson this PR broke the tests because the mock data was not updated to match the new parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108