Jump label tests #13
Merged
Jump label tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patching of jump label affected functions isn't actually supported by the upstream kernel. So kpatch-build will warn if a function uses jump labels. Copy convert-global-local test to be a failing test case, since it already fails for this reason. And then hex edit the original version to remove the jump table references to make it pass. FWIW, I believe the original objects were created with the following patch, originally for dynup/kpatch#658. diff -Nupr src.orig/mm/slub.c src/mm/slub.c --- src.orig/mm/slub.c 2017-11-17 15:58:51.157211972 -0500 +++ src/mm/slub.c 2017-11-17 15:58:56.808211972 -0500 @@ -3731,6 +3731,9 @@ void *__kmalloc(size_t size, gfp_t flags struct kmem_cache *s; void *ret; + if (!jiffies) + printk("kpatch kmalloc\n"); + if (unlikely(size > KMALLOC_MAX_CACHE_SIZE)) return kmalloc_large(size, flags); Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patching of jump label affected functions isn't actually supported
by the upstream kernel. So kpatch-build will warn if a function uses
jump labels.
Copy convert-global-local test to be a failing test case, since it
already fails for this reason. And then hex edit the original version
to remove the jump table references to make it pass.
FWIW, I believe the original objects were created with the following
patch, originally for dynup/kpatch#658.
diff -Nupr src.orig/mm/slub.c src/mm/slub.c
--- src.orig/mm/slub.c 2017-11-17 15:58:51.157211972 -0500
+++ src/mm/slub.c 2017-11-17 15:58:56.808211972 -0500
@@ -3731,6 +3731,9 @@ void *__kmalloc(size_t size, gfp_t flags
struct kmem_cache *s;
void *ret;
return kmalloc_large(size, flags);
Signed-off-by: Josh Poimboeuf jpoimboe@redhat.com