Skip to content

kpatch build is confused by kstrtab symbols #40

@jpoimboe

Description

@jpoimboe

Junliang Li reported this on the mailing list. The following patch fails:

Index: src/drivers/scsi/constants.c
===================================================================
--- src.orig/drivers/scsi/constants.c
+++ src/drivers/scsi/constants.c
@@ -1546,6 +1546,8 @@ void scsi_print_sense(char *name, struct
 {
    struct scsi_sense_hdr sshdr;

+   printk(KERN_INFO "\nkpatch code\n");
+
    scmd_printk(KERN_INFO, cmd, " ");
    scsi_decode_sense_buffer(cmd->sense_buffer, SCSI_SENSE_BUFFERSIZE,
                 &sshdr);

It fails with:

create-diff-object: kpatch_create_symbol_table: 372: local symbol __kstrtab_scsi_show_result starts at section offset 18, expected 0

It's getting confused by the __kstrtab_scsi_show_result symbol, which I think is created because of EXPORT_SYMBOL(scsi_show_result).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions