Skip to content

Conversation

@sumanthkorikkar
Copy link
Contributor

When CONFIG_COMPAT is disabled (No 31 bit emulation support), macro __S390_SYS_STUBx() is nop.
(See arch/s390/include/asm/syscall_wrapper.h).
Also, __SC_COMPAT_CAST definition is not available, which leads to build error.

Hence, __KPATCH_S390_SYS_STUBx() inherited from __S390_SYS_STUBx() macro, should point also point to nop when CONFIG_COMPAT is disabled.

…abled

When CONFIG_COMPAT is disabled (No 31 bit emulation support), macro
__S390_SYS_STUBx() is nop.
(See arch/s390/include/asm/syscall_wrapper.h).
Also, __SC_COMPAT_CAST definition is not available, which leads to build
error.

Hence, __KPATCH_S390_SYS_STUBx() inherited from __S390_SYS_STUBx() macro,
should point also point to nop when CONFIG_COMPAT is disabled.

Signed-off-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
@sumanthkorikkar sumanthkorikkar changed the title kpatch-syscall: Fix s390 build error when CONFIG_COMPAT is disabled kpatch-syscall: Fix kpatch s390 error when CONFIG_COMPAT is disabled Jan 3, 2025
Copy link
Contributor

@joe-lawrence joe-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sumanthkorikkar !

@joe-lawrence joe-lawrence merged commit 9ba1ce8 into dynup:master Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants