bugfix: correlate the rela sections of bundled static variables #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a static variable is a pointer, it has rela section. Example: static int *p = &a; changed to: static int *p = &b; so its rela section has changed. Then this change of data should be found and report error. But if we don't correlate its rela section, we won't find this change. Signed-off-by: Zhou ChengMing <zhouchengming1@outlook.com>
Member
|
Thanks @zhouchengming1. The patch looks good to me. Do you happen to have an example patch which produces this bug? |
Contributor
Author
|
Sorry, I don't have an example patch like this. I just find the bug when watch the code. |
sjenning
added a commit
that referenced
this pull request
Oct 14, 2015
bugfix: correlate the rela sections of bundled static variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a static variable is a pointer, it has rela section.
Example:
static int *p = &a;
changed to:
static int *p = &b;
so its rela section has changed.
Then this change of data should be found and report error.
But if we don't correlate its rela section, we won't
find this change.
Signed-off-by: Zhou ChengMing zhouchengming1@outlook.com