kpatch-build: verify bss/data/init section change properly #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpatch_verify_patchability can detect the change of .bss or .data or .init section, but it must be processed before verify num_changed. Otherwise, for example, if only .init section changed, it will fail with 'no changed functions were found', but not 'unsupported section change(s)'. With this patch, for .init section: .init section will not a bundled section, so if the section changed, not sync the function status, kpatch_verify_patchability will give 'changed section <secname> not selected for inclusion' and 'unsupported section change(s)' error. for .bss/.data section: kpatch_verify_patchability will ensure not including .data or .bss section, otherwise it will give 'data section <secname> selected for inclusion' and 'unsupported section change(s)' error. Signed-off-by: Li Bin <huawei.libin@huawei.com>
Member
|
👍 |
sjenning
added a commit
that referenced
this pull request
Oct 15, 2015
kpatch-build: verify bss/data/init section change properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kpatch_verify_patchability can detect the change of .bss or .data or
.init section, but it must be processed before verify num_changed.
Otherwise, for example, if only .init section changed, it will fail
with 'no changed functions were found', but not 'unsupported section
change(s)'.
With this patch,
for .init section: .init section will not a bundled section, so if
the section changed, not sync the function status, kpatch_verify_patchability
will give 'changed section not selected for inclusion' and
'unsupported section change(s)' error.
for .bss/.data section: kpatch_verify_patchability will ensure not
including .data or .bss section, otherwise it will give 'data section
selected for inclusion' and 'unsupported section change(s)'
error.
Signed-off-by: Li Bin huawei.libin@huawei.com