Skip to content

kpatch-build: 'hint' is not needed in kpatch_create_*_sections() #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joe-lawrence merged 1 commit into from
Feb 22, 2018
Merged

kpatch-build: 'hint' is not needed in kpatch_create_*_sections() #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions kpatch-build/create-diff-object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2190,7 +2190,7 @@ static struct sym_compare_type *kpatch_elf_locals(struct kpatch_elf *kelf)
}

static void kpatch_create_patches_sections(struct kpatch_elf *kelf,
struct lookup_table *table, char *hint,
struct lookup_table *table,
char *objname)
{
int nr, index, objname_offset;
Expand Down Expand Up @@ -2226,8 +2226,8 @@ static void kpatch_create_patches_sections(struct kpatch_elf *kelf,
if (sym->bind == STB_LOCAL) {
if (lookup_local_symbol(table, sym->name,
&result))
ERROR("lookup_local_symbol %s (%s)",
sym->name, hint);
ERROR("lookup_local_symbol %s",
sym->name);
} else {
if(lookup_global_symbol(table, sym->name,
&result))
Expand Down Expand Up @@ -2304,7 +2304,7 @@ static int kpatch_is_core_module_symbol(char *name)

static void kpatch_create_intermediate_sections(struct kpatch_elf *kelf,
struct lookup_table *table,
char *hint, char *objname,
char *objname,
char *pmod_name)
{
int nr, index;
Expand Down Expand Up @@ -2408,8 +2408,8 @@ static void kpatch_create_intermediate_sections(struct kpatch_elf *kelf,
ret = lookup_local_symbol(table,
rela->sym->name, &result);
if (ret)
ERROR("lookup_local_symbol %s:%s needed for %s",
hint, rela->sym->name, sec->base->name);
ERROR("lookup_local_symbol %s needed for %s",
rela->sym->name, sec->base->name);

}
else if (vmlinux) {
Expand Down Expand Up @@ -2913,8 +2913,8 @@ int main(int argc, char *argv[])

/* create strings, patches, and dynrelas sections */
kpatch_create_strings_elements(kelf_out);
kpatch_create_patches_sections(kelf_out, lookup, hint, objname);
kpatch_create_intermediate_sections(kelf_out, lookup, hint, objname, pmod_name);
kpatch_create_patches_sections(kelf_out, lookup, objname);
kpatch_create_intermediate_sections(kelf_out, lookup, objname, pmod_name);
kpatch_create_kpatch_arch_section(kelf_out, objname);
kpatch_create_hooks_objname_rela(kelf_out, objname);
kpatch_build_strings_section_data(kelf_out);
Expand Down