create-diff-object: fix ppc64le static local variable correlation #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ppc64le, the static local variable correlation doesn't take into account the .toc rela indirection for data references, meaning that it's basically broken in many cases. Fix it by making the code .toc-aware. Fixes dynup#793. Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Member
Author
|
@kamalesh-babulal What do you think about this approach to fix #793? |
kamalesh-babulal
approved these changes
Apr 5, 2018
This patch adds a reproducer testcase for correlating static local variables added in .rodata* section, ahead of .toc section. This testcase is for issue seen on PowerPC. For more details on the issue refer pull request: 793. It add's the testcase for: - Fedora-27 Kernel version 4.15.10-300 - Centos-7 Kernel version 3.10.0-693 and - Ubuntu-16.04 Kernel version 4.13.0-25.29 Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ppc64le, the static local variable correlation doesn't take into
account the .toc rela indirection for data references, meaning that it's
basically broken in many cases.
Fix it by making the code .toc-aware.
Fixes #793.
Reported-by: Kamalesh Babulal kamalesh@linux.vnet.ibm.com
Signed-off-by: Josh Poimboeuf jpoimboe@redhat.com