create-diff-object: skip dynrelas for function pointers to new functions #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dynup#755, we started using dynrelas for function pointers. However, this behavior only makes sense for function pointers to existing functions. For function pointers to *new* functions, just use a normal rela. The 'function-ptr-new' unit test is from the following patch: https://github.com/dynup/kpatch/files/1927198/new-static-callback.patch.txt Fixes dynup#834. Fixes: 495e619 ("kpatch-build, x86: do not use the patched functions as callbacks directly") Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
sm00th
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #755, we started using dynrelas for function pointers. However,
this behavior only makes sense for function pointers to existing
functions. For function pointers to new functions, just use a normal
rela.
The 'function-ptr-new' unit test is from the following patch:
https://github.com/dynup/kpatch/files/1927198/new-static-callback.patch.txt
Fixes #834.
Fixes: 495e619 ("kpatch-build, x86: do not use the patched functions as callbacks directly")
Signed-off-by: Josh Poimboeuf jpoimboe@redhat.com