fix: reclassify geminicli as native skill with global support#975
Open
mrfelton wants to merge 2 commits intodyoshikawa:mainfrom
Open
fix: reclassify geminicli as native skill with global support#975mrfelton wants to merge 2 commits intodyoshikawa:mainfrom
mrfelton wants to merge 2 commits intodyoshikawa:mainfrom
Conversation
Gemini CLI now has native skill support: it reads .gemini/skills/ directories with SKILL.md files out of the box. Changes: - Convert GeminiCliSkill from SimulatedSkill to ToolSkill (native) - Add proper frontmatter schema, validation, and toRulesyncSkill() - Enable global mode support (~/.gemini/skills/) - Update skills-processor metadata: supportsSimulated=false, supportsGlobal=true - Rewrite tests for native skill behavior Closes dyoshikawa#974
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #974 — Reclassifies the
geminiclitarget from a "simulated" skill to a nativeToolSkill, reflecting Gemini CLI's native skills support.Problem
GeminiCliSkillcurrently extendsSimulatedSkilland is marked withsupportsSimulated: true, which means:simulateSkills: true, geminicli is excluded from skill generation.gemini/skills/never gets populated by defaultChanges
src/features/skills/geminicli-skill.tsSimulatedSkill→ToolSkill(native base class)GeminiCliSkillFrontmatterSchema(zod/minilooseObjectwithname+description)validate(),getFrontmatter(),getBody(),toRulesyncSkill(),fromRulesyncSkill(),fromDir(),forDeletion(),isTargetedByRulesyncSkill(),getSettablePaths().gemini/skills/) and global (~/.gemini/skills/) modes supportedsrc/features/skills/skills-processor.tssupportsSimulated: false, supportsGlobal: truesrc/features/skills/geminicli-skill.test.tssrc/features/skills/skills-processor.test.tsgetToolTargets()assertions: geminicli now appears in default/native target listsEvidence
Gemini CLI officially supports the Agent Skills open standard:
.gemini/skills/(workspace) and~/.gemini/skills/(user)Testing
All existing tests pass with the changes. Test suite: 139 files, 3696 tests passing.