You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
after merging #283 , the old code is still working (old controllers/services), we need to migrate them to the new code and expose the APIs under /v2, bellow are the tasks needed to accomplish this:
Check List
Call /v2/Contributors endpoint from frontend, instead of old endpoint /Contributors, and remove the last.
The API code for Contributors Controller get method is here
The Frontend code for calling the old endpoint is here and here
Create /v2/GithubUsers endpoint and call it from frontend instead of /github/users, and remove the last.
You will create a new module api/src/github-user and inside you create your controller api/src/github-user/controller.ts similar to Contributors' controller. where you call the newly created method of GithubService.
Then update the frontend to call the new endpoint instead of the old one here and here
Description
after merging #283 , the old code is still working (old controllers/services), we need to migrate them to the new code and expose the APIs under
/v2, bellow are the tasks needed to accomplish this:Check List
/v2/Contributorsendpoint from frontend, instead of old endpoint/Contributors, and remove the last./v2/GithubUsersendpoint and call it from frontend instead of/github/users, and remove the last.api/src/github-userand inside you create your controllerapi/src/github-user/controller.tssimilar to Contributors' controller. where you call the newly created method of GithubService.Additional Comments
please create new PR for each task.