fix: guard detectPlanningLoop against non-array messages input#108
Merged
fix: guard detectPlanningLoop against non-array messages input#108
Conversation
The OpenCode plugin framework can pass {} instead of an array to
detectPlanningLoop via the session event handler, causing TypeError:
'{} is not iterable'. This made every HTTP request to the server
return 500, blocking E2E test suites.
Add Array.isArray guard at the top of detectPlanningLoop itself,
matching the existing pattern in buildTaskContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array.isArray(messages)guard at the top ofdetectPlanningLoopto preventTypeError: {} is not iterablewhen the OpenCode framework passes{}instead of an arrayContext
PR #106 added guards at the 4
client.session.messages()call sites, butdetectPlanningLoopitself could still receive non-array input from the plugin framework's internal call path (src/plugin/index.ts:90).