Conversation
…ves (#109) The time.completed check on the last assistant message was intended to catch ESC aborts (Issue #82), but it also suppressed reflection for sessions where the model stopped producing output without user intervention (context exhaustion, rate limits, network timeouts). - Remove time.completed guard from runReflection() - Add ABORT_RACE_DELAY (1.5s) in the session.idle handler so session.error can arrive first when the user presses ESC - Re-check recentlyAbortedSessions after the delay - Add Issue #109 regression tests in reflection.test.ts and abort-race.test.ts Closes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.completedguard (Issue Reflection plugin gives feedback when user stops the opencode session by clicking ESC. Critical bug. #82) treated missingtime.completedas an ESC aborttime.completedguard fromrunReflection()— ESC abort detection now relies solely on therecentlyAbortedSessionsmap (populated bysession.error)ABORT_RACE_DELAY(1.5s) in thesession.idlehandler to handle the race wheresession.idlefires beforesession.errorwhen user presses ESCChanges
reflection-3.tstime.completedguard, addABORT_RACE_DELAYconstant and post-delay abort re-checktest/reflection.test.tstest/abort-race.test.tsTesting
npm test: 319 passed, 5 skippednpm run eval:judge: 23/23 passednpm run eval:stuck: 12/12 passednpm run eval:compression: 12/12 passed