test(evals): fix anomalies and expand eval coverage#111
Open
test(evals): fix anomalies and expand eval coverage#111
Conversation
Fix 4 anomalies in existing eval assertions: - promptfooconfig.yaml #19: misleading description (said COMPLETE, asserted incomplete) - stuck-detection.yaml 'Task finished': loose assertion allowed reason=working - stuck-detection.yaml 'Very short delay': tautological assertion always passed - post-compression.yaml #2/#3: accepted continue_task when needs_github_update correct Add 19 new eval test cases: - 8 judge eval cases (23→31): mid-task stop, subtle warnings, retry loops, partial impl, gold-plating, context exhaustion, missing tests, main push - 6 stuck detection cases (12→18): retry loop, slow build, incomplete msg, planning-only, rate limited, stuck-not-complete - 5 post-compression cases (12→17): failing CI, mid-debug, multi-PR, blocked on secrets, force-push All evals pass: judge 31/31, stuck 18/18, compression 17/17. Unit tests: 319 passed, 5 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anomalies Fixed
promptfooconfig.yaml#19complete === falsestuck-detection.yaml"Task finished"reason: "working"as passingstuck-detection.yaml"Very short delay"stuck === false || shouldNudge === falsealways passedpost-compression.yaml#2/#3continue_taskwhenneeds_github_updatewas the correct answerNew Test Cases
Judge eval (8 new, 23→31 total):
Stuck detection (6 new, 12→18 total):
Post-compression (5 new, 12→17 total):