-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix: normalize Windows path separators across operatinos #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
dreyfus92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @outslept, LGTM 🫡
|
side note: we should expand on handling slashes on windows the spots below wont be working on windows, but that's the work for another PR
|
|
You know what. Lemme handle those as well. |
|
Should be good to go now. Only places where we have different path separators are codmods (perhaps shouldn't be an issue) and logs (debug/command output, but these are cosmetic anyways, we can get back to those later when tackling UI/UX). |
commit: |
fixes #50