Skip to content

Conversation

@outslept
Copy link
Contributor

@outslept outslept commented Jul 31, 2025

fixes #50

outslept and others added 2 commits August 1, 2025 02:54
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Copy link
Contributor

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @outslept, LGTM 🫡

@outslept outslept requested a review from 43081j August 1, 2025 10:39
@outslept
Copy link
Contributor Author

outslept commented Aug 1, 2025

side note: we should expand on handling slashes on windows

the spots below wont be working on windows, but that's the work for another PR

@outslept
Copy link
Contributor Author

outslept commented Aug 1, 2025

You know what. Lemme handle those as well.

@outslept outslept marked this pull request as draft August 1, 2025 10:48
@outslept outslept marked this pull request as ready for review August 1, 2025 11:05
@outslept outslept changed the title fix: normalize path separators in tarball file system fix: normalize Windows path separators across operatinos Aug 1, 2025
@outslept
Copy link
Contributor Author

outslept commented Aug 1, 2025

Should be good to go now. Only places where we have different path separators are codmods (perhaps shouldn't be an issue) and logs (debug/command output, but these are cosmetic anyways, we can get back to those later when tackling UI/UX).

@outslept outslept requested a review from 43081j August 3, 2025 23:04
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/e18e/cli/@e18e/cli@51

commit: 7160136

@43081j 43081j merged commit 323e749 into e18e:main Aug 4, 2025
5 checks passed
@outslept outslept deleted the fix/windows-path-separators branch August 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows path separator breaks tarball file lookup

3 participants