<Vishal> Added numeric decimal 128 constant data definition.#64
Merged
srinath-prabhu merged 2 commits intomainfrom Jul 21, 2025
Merged
<Vishal> Added numeric decimal 128 constant data definition.#64srinath-prabhu merged 2 commits intomainfrom
srinath-prabhu merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for numeric decimal 128-bit data types to the e6data vector system. The implementation extends the existing Thrift-based vector format to handle high-precision decimal values using binary representation.
- Added DECIMAL128 vector type enum and associated data structures
- Implemented binary-to-decimal conversion logic based on IEEE 754-2008 Decimal128 format
- Extended data processing pipeline to handle both constant and non-constant decimal128 vectors
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| e6x_vector.thrift | Added DECIMAL128 enum value and Decimal128Data/NumericDecimal128ConstantData structs |
| e6data_python_connector/e6x_vector/ttypes.py | Auto-generated Thrift bindings with new decimal128 support and updated compiler version |
| e6data_python_connector/e6x_vector/constants.py | Auto-generated constants file with compiler version update |
| e6data_python_connector/datainputstream.py | Implemented decimal128 binary conversion and vector processing logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.