Map TIMESTAMP_MILLIS to FROM_UNIXTIME#135
Merged
gauravdawar-e6 merged 1 commit intoe6data:mainfrom Jul 31, 2025
Merged
Conversation
96badba to
059411b
Compare
Adithyak-0926
previously approved these changes
Jul 31, 2025
193d7da
- Add TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions to Spark parser (Spark 3.1+) - Add TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions to Databricks parser - Convert microseconds to milliseconds by dividing by 1000 in E6 dialect - Use proper UnixToTime scale constants for consistency across dialects
1f5c1ef to
a5ed2c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TIMESTAMP_MILLIS(x)to E6FROM_UNIXTIME_WITHUNIT(x, 'milliseconds')Changes
expressions.py- Avoids unnecessary class proliferationTest plan
TIMESTAMP_MILLIS(1230219000123)→ E6FROM_UNIXTIME_WITHUNIT(1230219000123, 'milliseconds')