Skip to content

Add GROUP BY ALL and statistical functions support#139

Merged
gauravdawar-e6 merged 5 commits intoe6data:mainfrom
tkaunlaky-e6:mapping-statistical-functions
Jul 31, 2025
Merged

Add GROUP BY ALL and statistical functions support#139
gauravdawar-e6 merged 5 commits intoe6data:mainfrom
tkaunlaky-e6:mapping-statistical-functions

Conversation

@tkaunlaky-e6
Copy link

Summary

  • Added GROUP BY ALL to E6 dialect supported functions list
  • Added comprehensive test cases for GROUP BY ALL functionality
  • Includes statistical functions (COVAR_SAMP, VARIANCE_SAMP, VAR_SAMP) support

Test plan

  • All 859 tests pass
  • GROUP BY ALL transpilation verified from Databricks to E6
  • Comprehensive test coverage for various GROUP BY ALL scenarios

- Kept statistical functions (COVAR_SAMP, VARIANCE_SAMP, VAR_SAMP) in e6 supported functions
- Resolved test file conflicts
- Maintained GROUP BY ALL support
@tkaunlaky-e6
Copy link
Author

@Adithyak-0926 Done with resolving merge conflicts

"LAST_DAY_OF_MONTH",
"FORMAT_DATETIME",
"COUNT_IF",
"WIDTH_BUCKET",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are all these removed?

Tanay Kulkarni added 2 commits July 31, 2025 13:28
…by_all

- Restored missing test_random function with proper RAND() validation across all dialects
- Fixed test structure that was accidentally merged
- Maintained comprehensive GROUP BY ALL tests
- Preserved all statistical function tests (STDDEV, COVAR_SAMP, VARIANCE_SAMP, VAR_SAMP)
- Both test_random and test_group_by_all functions now exist properly
- Merge statistical functions support (CORR, COVAR_POP, COVAR_SAMP, VARIANCE_SAMP, VAR_SAMP)
- Add GROUP BY ALL support
- Integrate TYPEOF, TIMEDIFF, and INTERVAL functions
- Update supported functions list for e6 dialect
Copy link
Collaborator

@gauravdawar-e6 gauravdawar-e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gauravdawar-e6 gauravdawar-e6 merged commit 32065ce into e6data:main Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants