Merged
Conversation
PLT-6597 - IAM authetication
Contributor
There was a problem hiding this comment.
Pull Request Overview
This internal PR introduces a new variable (debug_namespaces) to support improved logging and debugging, updates authentication methods for AWS EKS providers using tokens instead of exec, and adds new IAM policies for system table access.
- Added the debug_namespaces variable to multiple tfvars and variables files.
- Updated provider configurations in eks.tf and support.tf to use token-based authentication via aws_eks_cluster_auth data sources.
- Introduced a new IAM policy (system_tables_policy) for both existing and new EKS setups.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aws/e6data_with_new_eks/terraform.tfvars | Added debug_namespaces variable. |
| aws/e6data_with_new_eks/support.tf | Replaced karpenter block with debug_namespaces mapping. |
| aws/e6data_with_new_eks/karpenter-provisioner-manifests/nodeclass.yaml | Removed static CPU manager configuration (cpuManagerPolicy). |
| aws/e6data_with_new_eks/helm.tf | Removed lifecycle block ignoring values changes. |
| aws/e6data_with_new_eks/eks.tf | Switched to token-based authentication using aws_eks_cluster_auth. |
| aws/e6data_with_new_eks/e6data_engine_iam.tf | Added system_tables_policy to IAM role managed_policy_arns. |
| aws/e6data_with_existing_vpc/variables.tf | Added debug_namespaces variable and local cross_account_id. |
| aws/e6data_with_existing_vpc/terraform.tfvars | Added debug_namespaces variable. |
| aws/e6data_with_existing_vpc/support.tf | Updated providers to use token-based authentication (potential ref error). |
| aws/e6data_with_existing_vpc/eks.tf | Switched to token-based authentication via aws_eks_cluster_auth. |
| aws/e6data_with_existing_vpc/e6data_engine_iam.tf | Added system_tables_policy for system table role assumption. |
Comments suppressed due to low confidence (1)
aws/e6data_with_existing_vpc/support.tf:82
- The token is being fetched from 'data.aws_eks_cluster_auth.current.token', but the data block is defined as 'target_eks_auth'. Update the reference to 'data.aws_eks_cluster_auth.target_eks_auth.token'.
token = data.aws_eks_cluster_auth.current.token
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
srinath-prabhu
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.