Skip to content

Internal#182

Merged
srinath-prabhu merged 24 commits intomainfrom
internal
Jun 16, 2025
Merged

Internal#182
srinath-prabhu merged 24 commits intomainfrom
internal

Conversation

@Harshithraj24
Copy link
Contributor

No description provided.

@srinath-prabhu srinath-prabhu requested a review from Copilot June 16, 2025 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This internal PR introduces a new variable (debug_namespaces) to support improved logging and debugging, updates authentication methods for AWS EKS providers using tokens instead of exec, and adds new IAM policies for system table access.

  • Added the debug_namespaces variable to multiple tfvars and variables files.
  • Updated provider configurations in eks.tf and support.tf to use token-based authentication via aws_eks_cluster_auth data sources.
  • Introduced a new IAM policy (system_tables_policy) for both existing and new EKS setups.

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
aws/e6data_with_new_eks/terraform.tfvars Added debug_namespaces variable.
aws/e6data_with_new_eks/support.tf Replaced karpenter block with debug_namespaces mapping.
aws/e6data_with_new_eks/karpenter-provisioner-manifests/nodeclass.yaml Removed static CPU manager configuration (cpuManagerPolicy).
aws/e6data_with_new_eks/helm.tf Removed lifecycle block ignoring values changes.
aws/e6data_with_new_eks/eks.tf Switched to token-based authentication using aws_eks_cluster_auth.
aws/e6data_with_new_eks/e6data_engine_iam.tf Added system_tables_policy to IAM role managed_policy_arns.
aws/e6data_with_existing_vpc/variables.tf Added debug_namespaces variable and local cross_account_id.
aws/e6data_with_existing_vpc/terraform.tfvars Added debug_namespaces variable.
aws/e6data_with_existing_vpc/support.tf Updated providers to use token-based authentication (potential ref error).
aws/e6data_with_existing_vpc/eks.tf Switched to token-based authentication via aws_eks_cluster_auth.
aws/e6data_with_existing_vpc/e6data_engine_iam.tf Added system_tables_policy for system table role assumption.
Comments suppressed due to low confidence (1)

aws/e6data_with_existing_vpc/support.tf:82

  • The token is being fetched from 'data.aws_eks_cluster_auth.current.token', but the data block is defined as 'target_eks_auth'. Update the reference to 'data.aws_eks_cluster_auth.target_eks_auth.token'.
token                  = data.aws_eks_cluster_auth.current.token

@srinath-prabhu srinath-prabhu merged commit 5013027 into main Jun 16, 2025
@srinath-prabhu srinath-prabhu deleted the internal branch June 16, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants