fix: QA rounds 3-6 — B58-B64 fixed, 10 tmux flows, promptable agent switching#33
Merged
fix: QA rounds 3-6 — B58-B64 fixed, 10 tmux flows, promptable agent switching#33
Conversation
added 2 commits
March 22, 2026 04:33
B58: pluginGuard() now catches Plugin.trigger() errors and returns EditResult error instead of propagating uncaught exception. B59: pluginNotify() now catches Plugin.trigger() errors and logs warning instead of silently ignoring. BUGS.md cleaned up: - Removed duplicate "Open — Bugs (0)" section - Added B58-B59 as fixed - Added 10 new false positives from QA analysis (V1, R4, E1-fork, PM1, PM2, etc.) — each verified with reasoning - Updated Q3 reference from "this PR" to "PR #31" - Total: 0 open bugs, 64 fixed, 15 false positives documented
Third round of deep analysis covering: session management, compaction, prompt pipeline, skill/scripts, command templates, truncation. All areas clean. All previous fixes (B48, B38, B57) verified holding. New false positives (5): - updatePart() orphaned parts → FK constraint prevents - Script paths with spaces → array-based execution is safe - Truncation boundary at maxBytes → comparison is correct - Compaction during prompt → BusyError prevents - filterEdited + sweep same part → orthogonal concerns Total: 0 open bugs, 20 verified false positives.
e6qu
changed the title
…tion proof tests B60 (Med): Objective text injected directly into system prompt markdown. Newlines and markdown chars (backticks, headers) could break formatting. Fix: escape newlines and markdown special chars before injection. Sweep error logging: Database.transaction() in sweep() now wrapped in try-catch with log.error() instead of silent failure. Integration proof tests (3 new): - PROOF: hide() removes content from LLM context, CAS preserves original - PROOF: unhide() restores original content from CAS - PROOF: mark discardable + sweep removes content after N turns Each test creates a real session with messages, performs the edit operation, then verifies the content IS present before and IS NOT present after (or vice versa for unhide). CAS storage verified independently. Cross-module false positives documented (3 new): - Protected message window timing → benign race - Side thread system prompt staleness → fresh DB query per prompt - Sweep transaction failure → now logged tmux TUI tests: all 5 flows pass including LLM submit-message and cost-dialog.
e6qu
changed the title
added 2 commits
March 22, 2026 05:35
…uide Added to docs/context-editing.md: - Direct prompts to trigger context editing (hide, replace, externalize, mark, park) - Complete slash command reference (/focus, /focus-rewrite-history, /btw, /reset-context, /classify, /threads, /history, /tree) - How to enable focus agents in opencode.json config - How history editing is verified (integration proof tests)
…witching - B61: MCP add() inconsistent return type (Status vs Record) — all branches now return Record - B62: text part timing start overwritten at stream end — preserve original start - B63: unguarded JSON.parse on ripgrep output — flatMap with try-catch - B64: untracked file line count off-by-one — trimEnd before split - 5 new tmux test flows (slash-command, multi-agent-verify, slash-classify, slash-threads, slash-history) — 10 total - Promptable agent mode switching: updated plan_enter/plan_exit tool descriptions for autonomous back-and-forth switching - Documented mode switching flow in docs/agents.md - 23 new false positives verified (49 total in BUGS.md)
e6qu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep QA across 4 rounds (rounds 3-6), covering bug fixes, false positive verification, tmux visual testing, and feature documentation.
Bug fixes (7)
pluginGuard()uncaughtPlugin.trigger()errors — try-catch → EditResult errorpluginNotify()silentPlugin.trigger()errors — try-catch → log.warnadd()inconsistent return type (StatusvsRecord) — all branches return RecordJSON.parseon ripgrep output — flatMap with try-catch, log.warntrimEnd()before splitTesting (10 tmux flows)
False positives verified (49 total)
Features
docs/agents.md— Build ↔ Plan viaplan_enter/plan_exittoolsdocs/context-editing.mdTest plan
bun test --timeout 30000— 1515 pass, 0 failbun test/cli/tui/tmux-tui-test.ts— 10 flows passnpx tsgo --noEmit— 0 errors (packages/opencode)